Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the target file in the Model #40869

Merged
merged 2 commits into from
May 30, 2024
Merged

Set the target file in the Model #40869

merged 2 commits into from
May 30, 2024

Conversation

gastaldi
Copy link
Contributor

This is necessary so maven-model-helper can know which pom.xml the change refers to.

@quarkus-bot quarkus-bot bot added the area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins label May 28, 2024
@gastaldi gastaldi requested a review from gsmet May 28, 2024 14:18
@gastaldi gastaldi requested a review from aloubyansky May 28, 2024 14:40

This comment has been minimized.

@quarkus-bot quarkus-bot bot added the area/platform Issues related to definition and interaction with Quarkus Platform label May 29, 2024
@gastaldi gastaldi requested a review from gsmet May 29, 2024 19:37
@gsmet
Copy link
Member

gsmet commented May 30, 2024

It looks good to me but I'd like to give it a try since apparently CI didn't catch the issue. Probably not today though.
@gastaldi did you get why our core CI missed it? IIRC you added tests so I'm surprised we didn't catch the regression.

@gsmet gsmet merged commit 8d30b16 into quarkusio:main May 30, 2024
51 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.12 - main milestone May 30, 2024
@gsmet
Copy link
Member

gsmet commented May 30, 2024

Tested and it works!

@gastaldi gastaldi deleted the fix_indent branch May 30, 2024 15:28
jcarranzan added a commit to jcarranzan/quarkus-test-suite that referenced this pull request Jun 4, 2024
@gsmet gsmet modified the milestones: 3.12 - main, 3.8.5 Jun 4, 2024
jcarranzan added a commit to jcarranzan/quarkus-test-suite that referenced this pull request Jun 4, 2024
jcarranzan added a commit to jcarranzan/quarkus-test-suite that referenced this pull request Jun 5, 2024
rsvoboda pushed a commit to quarkus-qe/quarkus-test-suite that referenced this pull request Jun 6, 2024
fedinskiy pushed a commit to fedinskiy/quarkus-test-suite that referenced this pull request Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/platform Issues related to definition and interaction with Quarkus Platform kind/bugfix triage/flaky-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

POM is not preserved when we add or remove extensions with CLI
2 participants